Stricter JSON parse when content-type header is application/json. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natevw
added a commit
that referenced
this pull request
Dec 5, 2012
Stricter JSON parse when content-type header is application/json.
|
Ah, hmm. Forgot this had switched over to mikeal's request library...so is req.body normally converted automatically and our code is just a backup? Was going to just clean up and release a minor update but please could you look into this? (I'm in CET and really must be sleeping now, but will try move this forward in my morning.) |
|
Hi @natevw. I really appreciate you looking at this so quickly. I replied to inline comments above. Happy to discuss more tomorrow and have a good night. |
|
Heh, didn't realize that this lib was still v0.2 so just a minor release should suffice. Just |
|
Cheers. Again, grateful for the fast response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little fix to address a problem we had during the Chargify datacenter migration last weekend. Their API was not returning a complete response and therefore the JSON was invalid. Instead of being caught at the source, the unpatched code would allow the body to slip by as a string, causing potential havoc downstream when code get a string instead of an object.
Would love to get this in a release if you have a moment, @natevw.
Thanks!